New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close js and css files after opening #1084

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
2 participants
@basnijholt
Contributor

basnijholt commented Jan 27, 2017

I often get warnings like:

/home/tinkerer/Dropbox/Work/holoviews/holoviews/plotting/renderer.py:412: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/tinkerer/Dropbox/Work/holoviews/holoviews/plotting/widgets/widgets.js' mode='r' encoding='UTF-8'>
  if f is not None )
/home/tinkerer/Dropbox/Work/holoviews/holoviews/plotting/renderer.py:412: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/tinkerer/Dropbox/Work/holoviews/holoviews/plotting/mpl/mplwidgets.js' mode='r' encoding='UTF-8'>
  if f is not None )
/home/tinkerer/Dropbox/Work/holoviews/holoviews/plotting/renderer.py:414: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/tinkerer/Dropbox/Work/holoviews/holoviews/plotting/widgets/jsslider.css' mode='r' encoding='UTF-8'>
  for f in css if f is not None)

This PR should fix this.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 27, 2017

Good catch. Looks good to me, merging.

@philippjfr philippjfr merged commit c07680f into ioam:master Jan 27, 2017

2 of 3 checks passed

s3-reference-data-cache Tests still building.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 77.576%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment