New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for datetime support on bokeh BoxPlot #1086

Merged
merged 3 commits into from Jan 30, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jan 27, 2017

Bokeh does not currently handle datetimes on their boxwhisker chart implementation, in the meantime this PR simply casts the datetimes to strings, replacing any colons with semi-colons because those are also not supported. I'll file an issue about it on the bokeh repo, but since the charts API may get deprecated it may not get addressed.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 29, 2017

I would like to hear what the Bokeh devs have to say before merging - this issue of not supporting colons is very weird!

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 30, 2017

Here's the issue on it: bokeh/bokeh#516, currently marked 0.12.5. In the meantime I need this for a project, so I'd suggest we merge and I'll open an issue to follow up on, which can hopefully be merged before 1.7 is released.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 30, 2017

... so I'd suggest we merge and I'll open an issue to follow up on, which can hopefully be merged before 1.7 is released.

Sounds good.

@jlstevens jlstevens merged commit bcf4b23 into master Jan 30, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 77.595%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr deleted the bokeh_box_timeseries branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment