New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed python3 'lod' bug #1115

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 9, 2017

Fix for #1005. Still don't know what actually caught the bug as 'lod' should always be available in the defaults but this will fix the immediate issue.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 9, 2017

Ready to merge when tests pass.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 9, 2017

I remember suggesting this as a temporary fix and I am happy to merge. I'm just wondering what we can do to try and address the underlying issue?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 9, 2017

I'm just wondering what we can do to try and address the underlying issue?

Add a bunch of print statements to Parameterized.defaults, spawn 50 python3 processes which each instantiate a bokeh ElementPlot and call defaults on it, would be my only suggestion.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 9, 2017

Sounds like a real pain!

It isn't something we need to do now but maybe we should still have an issue to remind us that it is still an issue? What bad behavior can we expect when the lod is missing after this fix?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 9, 2017

What bad behavior can we expect when the lod is missing after this fix?

Unless someone sets an explicit lod configuration as a plot option it will make zero difference. If they do and this bug occurs then it will fall back to the lod defaults bokeh sets up for all the options the user didn't define.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 9, 2017

Ok. Doesn't sound too bad, but it is probably worth filing an issue just to register that we are aware of this issue.

Merging.

@jlstevens jlstevens merged commit 5278f85 into master Feb 9, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.169%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the lod_fix branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment