New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed group and label assignment bug in Element_Operation.__call__ #1119

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@drs251
Contributor

drs251 commented Feb 10, 2017

Reopen of PR #1110, to address issue #1106. @philippjfr Perhaps it will work this time, if not just go ahead and make your own PR - I really need more practice with git...

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 10, 2017

Thanks so much for going through the effort, practice makes perfect. I'm sure it'll work this time.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 10, 2017

Okay our test build issues persist but now it's on me to figure out a solution.

@philippjfr

Looks good and tests should pass shortly, will go ahead and merge when that happens.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 10, 2017

Tests passed at last. Thanks again and congrats on your first PR!

@philippjfr philippjfr merged commit 2654bd5 into ioam:master Feb 10, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 78.168%
Details
s3-reference-data-cache Test data is cached.
Details
@drs251

This comment has been minimized.

Contributor

drs251 commented Feb 10, 2017

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment