New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct dpi in MPLRenderer.get_size #1143

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 21, 2017

Following on from #1140 it turns out the matplotlib equivalent to get the plot size in pixels is also incorrect using the wrong dpi.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 21, 2017

I don't get why plot.state.dpi isn't always the right dpi value to use....why wouldn't it match self_or_cls.dpi if output by the same renderer?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 21, 2017

Because the dpi is controlled by the renderer and the plotting classes don't fiddle with the default dpi value on the figure.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 21, 2017

Ok. Is it ready to merge then?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 21, 2017

Yes.

@jlstevens jlstevens merged commit e5a9a6c into master Feb 21, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 78.197%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the mpl_get_size branch Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment