New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with no colorbar dimension and unicode label #1152

Merged
merged 1 commit into from Feb 28, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 25, 2017

Tiny little fix that allows a colorbar to be drawn for data with no corresponding dimension (e.g. aggregated counts) and fixes a usage of str(dimension) which is not unicode safe.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 27, 2017

Looks good but seems to have affected the test data which will need to be checked/updated.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 28, 2017

Tests are now passing. Merging.

@jlstevens jlstevens merged commit 96c36df into master Feb 28, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on allow_no_dim_cbar at 78.35%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the allow_no_dim_cbar branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment