Fixed issue with no colorbar dimension and unicode label #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
allow_no_dim_cbar
branch
from
13ab9a1
to
91d0206
Compare
|
Looks good but seems to have affected the test data which will need to be checked/updated. |
philippjfr
force-pushed
the
allow_no_dim_cbar
branch
from
91d0206
to
03341f7
Compare
|
Tests are now passing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny little fix that allows a colorbar to be drawn for data with no corresponding dimension (e.g. aggregated counts) and fixes a usage of
str(dimension)which is not unicode safe.