New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various unit tests #1153

Merged
merged 2 commits into from Feb 27, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 26, 2017

No description provided.

@philippjfr philippjfr added testing WIP and removed WIP labels Feb 26, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 27, 2017

My only issue with this PR is you didn't report the coverage increase. I guess we'll see it now on master! ;-p

Merging.

@jlstevens jlstevens merged commit be6cf79 into master Feb 27, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 78.328%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details
@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 27, 2017

It's tiny :(

@philippjfr philippjfr deleted the various_unit_tests branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment