New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usages of len(Element) #1155

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 26, 2017

We've decided to avoid using len(Element) wherever possible.

@philippjfr philippjfr requested a review from jlstevens Feb 26, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 27, 2017

Happy to merge - I'm just wondering if these were new instances of len that are being removed again or whether these were missed in an earlier PR when we first discouraged using len...

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 27, 2017

I think we just missed these, I've had this fix sitting in my stashes a while so possibly I just forgot to commit them at the time.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 27, 2017

Ok, looks good!

@jlstevens jlstevens merged commit fd65ac7 into master Feb 27, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.178%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the no_length branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment