New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib boxplot bug #1163

Merged
merged 3 commits into from Feb 28, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 27, 2017

BoxPlot raises an error when put in a Layout currently, small fix to ensure it doesn't. Also snuck in a style parameter for HistogramPlot.

style.pop('zorder')
style.pop('label')
style.pop('zorder', None)
style.pop('label', None)

This comment has been minimized.

@jlstevens

jlstevens Feb 27, 2017

Member

None is the default if unset? If you just want to remove these keys we might want to switch to:

style = {k:v for k,v in style.items() if k not in ['zorder', 'label']}

I might prefer this to using pop, especially as you aren't using the popped value(s).

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 28, 2017

Looks good. Merging.

@jlstevens jlstevens merged commit 3aa315f into master Feb 28, 2017

3 of 4 checks passed

s3-reference-data-cache Test data not cached, see details to rebuild.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 78.362%
Details

@philippjfr philippjfr deleted the mpl_chart_fixes branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment