New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly import top-level util module #1164

Merged
merged 1 commit into from Feb 28, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 27, 2017

Fixes #1134

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 28, 2017

Glad this is fixed, but can you explain it to me?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 28, 2017

Honestly, I can't. Apparently a module has to exported with an explicit import and since we have from __future__ import absolute_imports enabled and:

import .util

isn't valid syntax, this was the only thing left to try and it seems to work.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 28, 2017

Whatever it was, glad it is fixed! Merging.

@jlstevens jlstevens merged commit 451d4e1 into master Feb 28, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.363%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the top_level_util branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment