New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filtering of bokeh LineAnnotationPlot properties #1169

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Mar 2, 2017

Minor self-explanatory fix.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 2, 2017

Looks good, happy to merge once the tests pass.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 2, 2017

Will have to add a dask 0.14 compatibility PR because they changed a bit of API, hopefully they can restore the correct behavior in 0.14.1.

@jbednar

This comment has been minimized.

Member

jbednar commented Mar 2, 2017

Have you filled an issue for dask pointing out the breaking change?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 2, 2017

Have you filled an issue for dask pointing out the breaking change?

Pinged the person responsibly after asking Matt about it. Temporarily pinned dask now. Once I've heard back we'll have to decide what to do.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 2, 2017

Temporarily pinned dask now

That means I can merge once the tests pass, right?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 2, 2017

That means I can merge once the tests pass, right?

Yes.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 2, 2017

Great!

The pr build has now passed and the push build will fail due to a transient. I don't see any reason to bother restarting the push build. Merging.

@jlstevens jlstevens merged commit 1c80711 into master Mar 2, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 78.348%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the vline_filter_props branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment