New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed top-level util import issue #1180

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Mar 7, 2017

As pointed out in #1134 (comment) it turns out my previous fix wasn't quite sufficient, the wildcard import from hv.core.spaces was overriding hv.util with hv.core.util. Ideally we should get rid of all wildcard imports to avoid issues like this.

@PeterDSteinberg

This comment has been minimized.

PeterDSteinberg commented Mar 7, 2017

I agree on getting rid of wildcard imports, or limiting their usage and using them only when __all__ has been defined.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 7, 2017

Right, I think we can easily replace the remaining wildcard import in the top-level __init__, the only one I would leave is for the element module, which does define __all__ and would be too much of a pain to list out explicitly.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 9, 2017

Just checked and all other imports define __all__. Ready to merge.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 9, 2017

Great!

@jlstevens jlstevens merged commit f87ca46 into master Mar 9, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on util_import at 78.43%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the util_import branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment