New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs in mpl colorbar arrows and Image.range #1211

Merged
merged 3 commits into from Mar 16, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Mar 16, 2017

In fixing a bug in the colorbars (#1109) I found a bug in handling partially bounded Dimension.range settings, e.g.:

hv.Image(np.array([[0, 1], [2, 3]]).redim(z=dict(range=(None, 2))).range('z')

Would report (0, 3) when all our other Elements respect explicitly set ranges. I'll probably open another PR to add an argument to the range method to ignore the soft_range and range on the Dimension. Knowing the actual data range is perhaps more useful and we should consider returning that by default and only returning Dimension.range when requested, which all the plotting code could do.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 16, 2017

Tests have passed. Ready to merge?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 16, 2017

Yes, ready to merge, I'll open the related issue now.

@jlstevens jlstevens merged commit 3658cbd into master Mar 16, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 78.604%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the mpl_colorbar_extend branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment