Handle bug in gridded groupby when dropping dimensions #1219

Merged
merged 1 commit into from Mar 21, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Mar 20, 2017

In certain scenarios dropping dimensions in a gridded groupby would not behave correctly. This fixes the bug and adds some tests.

@philippjfr philippjfr requested a review from jlstevens Mar 21, 2017

@philippjfr

This comment has been minimized.

Show comment
Hide comment
@philippjfr

philippjfr Mar 21, 2017

Member

Ready.

Member

philippjfr commented Mar 21, 2017

Ready.

@@ -117,7 +117,8 @@ def init(cls, eltype, data, kdims, vdims):
@classmethod
def validate(cls, dataset):
- pass
+ if len(dataset.vdims) > 1:

This comment has been minimized.

@jlstevens

jlstevens Mar 21, 2017

Member

Always good to have some extra validation!

@jlstevens

jlstevens Mar 21, 2017

Member

Always good to have some extra validation!

@jlstevens

This comment has been minimized.

Show comment
Hide comment
@jlstevens

jlstevens Mar 21, 2017

Member

Looks good and extra tests are always worthwhile. Merging.

Member

jlstevens commented Mar 21, 2017

Looks good and extra tests are always worthwhile. Merging.

@jlstevens jlstevens merged commit 2961d7d into master Mar 21, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 78.62%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the xarr_groupby_drop branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment