New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply matplotlib rc parameters correctly throughout #1225

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Mar 23, 2017

I've long struggled with the correct way to apply rcparams in matplotlib, I now think a decorator which is applied during axis/figure creation, for all initialize_plot and update_frame calls and during rendering is the best approach.

Fixes #1222

@philippjfr philippjfr requested a review from jlstevens Mar 23, 2017

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 23, 2017

Ready for review.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 23, 2017

Seems like a sensible approach and I am happy with it as long as it works - preferably better than before!

My only comment is that I think mpl_context should be called mpl_rc_context to be explicit.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 23, 2017

I suppose my only other comment is that it might be nice to test - if it is easy enough to set up such tests.

@jlstevens

Just rename mpl_context to mpl_rc_context and consider adding some tests if possible. Otherwise looks good.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 24, 2017

Ready now, pretty sure the coverage report is false, when I click through to it, it doesn't actually tell me which files now have reduced coverage.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 24, 2017

Ready now, pretty sure the coverage report is false

Yeah, a -1.4% coverage change is surprising.

Anyway, looks good and I'll now merge.

@jlstevens jlstevens merged commit 8974ed1 into master Mar 24, 2017

3 of 4 checks passed

coverage/coveralls Coverage decreased (-1.4%) to 76.988%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the mpl_rc_context branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment