New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a dynamic hist method #1227

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Mar 24, 2017

One of the last methods to implement to make the DynamicMap fully lazy as outlined in #422.

@philippjfr philippjfr added the feature label Mar 24, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 24, 2017

Looks good and the tests are passing (not that this is currently tested). It might be worth adding tests later but I am happy to merge right now.

@jlstevens jlstevens merged commit 1896f13 into master Mar 24, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 76.942%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the dyn_hist_method branch Apr 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment