New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ElementOperation to process NdLayout types #1228

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Mar 24, 2017

Partial fix for #1107, while we haven't addressed the issue about (Nd)Overlays, this is a straightforward addition that let's ElementOperations process NdLayouts just as it already handles GridSpaces.

@philippjfr philippjfr added the feature label Mar 24, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 24, 2017

Looks good and I see now reason why NdLayout should be excluded from operations.

I do think it might be worth adding a simple NdLayout operation in the unit tests to make sure the plumbing works as expected.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 24, 2017

Ready to merge.

@jlstevens jlstevens merged commit 5160d11 into master Mar 24, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 77.932%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the elop_ndlayout branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment