New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced extension logo parameter with banner toggle #1231

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
@jlstevens
Member

jlstevens commented Mar 28, 2017

This simple PR replaces the logo option of the notebook extension (which only toggled the logo) with a banner switch with can suppress both the logo and the loading message. Addresses #1186.

We'll need to mention the replacement of the logo parameter in the CHANGELOG but I don't think it is a big deal - the new behavior simply extends the old behavior and I don't think the logo parameter was used much anyway.

@jlstevens jlstevens changed the title from Replaced notebook extension logo toggle with banner toggle to Replaced extension logo parameter with banner toggle Mar 28, 2017

@jbednar

This comment has been minimized.

Member

jbednar commented Mar 28, 2017

Thanks. Will this still print a blank line, or will it avoid printing at all (preferred)?

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 28, 2017

Thanks. Will this still print a blank line, or will it avoid printing at all (preferred)?

I noticed a tiny it more whitespace than normal (i.e more than when you just enter None into a cell) but didn't manage to remove it, even after simplifying the template to just JS. Here is what I mean:

image

I assume this odd effect happens when there is JS code 'displayed' even though nothing should be visible (including that slightly larger white gap).

@jbednar

This comment has been minimized.

Member

jbednar commented Mar 29, 2017

I'm not so worried about what happens if the notebook_extension() call is the last line in the cell, but what happens if I then put some useful things with real output at the end of that same cell (e.g. "2.0") -- will the formatting then be messed up?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 29, 2017

I'm not so worried about what happens if the notebook_extension() call is the last line in the cell, but what happens if I then put some useful things with real output at the end of that same cell (e.g. "2.0") -- will the formatting then be messed up?

No, it'll behave as now and just put that bit of whitespace above your figure.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Mar 29, 2017

Ready to merge?

@jlstevens

This comment has been minimized.

Member

jlstevens commented Mar 29, 2017

Yup, I think so.

@philippjfr philippjfr merged commit 5e6d0d2 into master Mar 29, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.1%) to 78.053%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the extension_banner_option branch Mar 29, 2017

@jbednar

This comment has been minimized.

Member

jbednar commented Mar 29, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment