Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Simplified operation modes supported by Dynamicmap #1238
This PR greatly simplified DynamicMap, removing all concept of 'modes' except for 'sampled' mode: 'open', 'bounded', 'generator' and 'counter' mode are all gone (implicitly DynamicMaps are now always 'bounded').
In addition, keys cannot be returned by the callback.
The following items will be assigned to a follow up PR after this one is merged.
I might recommend leaving the last point (updating the tutorials) for another PR - the earlier this is merged, the better tested it will be before release and the bigger chance we can hear any objections from our users. We don't think anyone has ever really other used anything other than 'bounded' mode with callables (possibly with streams) but we can't be certain.
@philippjfr I now think this PR should be about cleaning things up only.
Once we have removed everything we want to, I think we should merge and I'll follow up with a PR to add things back (updating docs, adding tests, adding more validation etc).
I will delete the bits in the DynamicMap tutorial that are out of date (it might no longer be a coherent story but that is what I'll fix in the next PR). Sound reasonable?
I've now removed the sections of the DynamicMap tutorial that no longer apply - everything still in the notebook works as before. In the next PR I'll rewrite this tutorial to try and cover the same sort of examples but using streams. We might also want to decide on how to split between a DynamicMap tutorial and a streams tutorial.
@philippjfr I think this PR is ready for review - is there anything else that can be cleaned up and removed before I work on reintroducing things?