New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for handling coloring in plotting #1249

Merged
merged 4 commits into from Apr 7, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 7, 2017

Fixes some small bugs introduced in #1241 and reported as bugs in #1248.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 7, 2017

Any way to add tests to make sure there isn't another regression?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 7, 2017

Writing some right now.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 7, 2017

Ready to merge whenever, tests passed and I only added a comment.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 7, 2017

The pr build passed at least. Merging.

@jlstevens jlstevens merged commit 6970733 into master Apr 7, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 78.611%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the bokeh_color_fixes branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment