New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logging output support to unittests #1259

Merged
merged 5 commits into from Apr 10, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Apr 10, 2017

This PR allows us to finally check param's logging output. We have often wanted to check the output of param.warning but haven't had the infrastructure to do so. This is important as we want to improve exceptions and warnings throughout HoloViews.

This PR includes an example of how the new LoggingComparisonTestCase is used, involving a recent unit test where I wanted to check the param.warning output.

I'll be using this new system in a number of new unit tests I am planning but I don't intend to go back and update all the existing tests right now as it would take some thought to figure out where logging output should be checked. That could be work for a future PR and could be something to do before HoloViews 2.0.

@jlstevens jlstevens added the ready label Apr 10, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 10, 2017

@philippjfr I want this to be a quick PR and I do think it is ready to review/merge once the tests go green.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 10, 2017

Looks good.

@philippjfr philippjfr merged commit d75f3d5 into master Apr 10, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on logging_unittests at 78.895%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the logging_unittests branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment