New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed Element to mpl ElementPlot._finalize_axis #1269

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 11, 2017

In debugging another issue I found that matplotlib plots are not correctly handling DynamicMaps of overlays as ElementPlots are not passing the currently displayed Element to the _finalize_axis method. This means that the method does an additional lookup which fails when the data comes from a DynamicMap returning Overlays.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 11, 2017

Is this PR ready to review/merge?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 11, 2017

Yes, ready.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 11, 2017

Looks good and the tests are passing. Merging.

@jlstevens jlstevens merged commit c6629c1 into master Apr 11, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.0007%) to 78.994%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the mpl_finalize branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment