New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure old paths aren't dropped when combining Layouts #1271

Merged
merged 3 commits into from Apr 11, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 11, 2017

Fixes bug encountered when adding another plot to a collated Layout. The main issue seems to be that it ignored custom paths which do not match the auto-computed paths generated by computing a path from the group and label.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 11, 2017

Ok, the change here is simple but the layout code can be tricky. I hope the tests all pass!

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 11, 2017

Test have passed. Best to merge early to help us catch any other issues.

@jlstevens jlstevens merged commit 255445e into master Apr 11, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on layout_path_inheritance at 79.026%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the layout_path_inheritance branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment