New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option system improvements #1275

Merged
merged 6 commits into from Apr 11, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Apr 11, 2017

This PR aims to tackle several outstanding issues regarding the option system. To start with, issue #1105 has been resolved. This PR is currently WIP and I'll mention the other issues that have been addressed here as I get to them.

Edit: This PR now addresses issue #625 as well.

@jlstevens jlstevens added the WIP label Apr 11, 2017

@jlstevens jlstevens added this to the v1.7.0 milestone Apr 11, 2017

@jlstevens jlstevens added ready and removed WIP labels Apr 11, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 11, 2017

@philippjfr I think it is ready to review/merge once the tests pass. Even if it isn't perfect, it addresses the two issues mentioned and I can fold any subsequent feedback into my next PR which is also about the options system (and a bit more involved).

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 11, 2017

Looks good, glad this is getting validated (again?).

@philippjfr philippjfr merged commit f78f51f into master Apr 11, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 79.03%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the option_system_improvements branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment