New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow casting Image to QuadMesh #1282

Merged
merged 1 commit into from Apr 12, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 12, 2017

This reapplies #1223 as it seems to have gotten lost when rebasing the image interface.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 12, 2017

Looks good. Merge when the tests pass or should there be a unit test or two to make sure this functionality doesn't get lost again?

@philippjfr philippjfr added the API label Apr 12, 2017

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 12, 2017

QuadMesh will get a rewrite soon anyway, just go ahead and merge for now.

@jlstevens jlstevens merged commit b095fb7 into master Apr 12, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 79.019%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the quadmesh_cast branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment