New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure max_cycles persists on style for non-batched plots #1288

Merged
merged 2 commits into from Apr 13, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 13, 2017

Fixes a bug where in non-batched mode the max_cycles on styles would be reset causing Palettes to work incorrectly. Going to try adding some tests for this.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 13, 2017

Ready to merge.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 13, 2017

Looks good. Merging.

@jlstevens jlstevens merged commit acfb0ad into master Apr 13, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 78.801%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr deleted the cyclic_styles_nonbatched branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment