New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed py3 bug on Renderer.export_widgets #1289

Merged
merged 1 commit into from Apr 13, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 13, 2017

Renderer.export_widgets wasn't correctly declaring it was writing bytes.

Fixes #1234

@philippjfr philippjfr added the bug label Apr 13, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 13, 2017

Great you found it!

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 13, 2017

Also messed with the options on a subsequent plot, rebuilding the test data.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 13, 2017

Ready to merge.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 13, 2017

Merging.

@jlstevens jlstevens merged commit 20b1e19 into master Apr 13, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.81%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the renderer_export_widgets_fix branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment