New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored logo parameter and removed banner text #1291

Merged
merged 1 commit into from Apr 14, 2017

Conversation

Projects
None yet
3 participants
@jlstevens
Member

jlstevens commented Apr 14, 2017

This PR reverts the changes of PR #1231 after the discussion in issue #1186.

The logo switch has now been restored and the banner message disabled In HoloViews 2.0 we would like a logo per backend (or better, combine logos somehow?)

Here is the new behavior:

image

@jlstevens jlstevens added the ready label Apr 14, 2017

@jlstevens jlstevens changed the title from Restored notebook_extension logo parameter and removed banner text to Restored logo parameter and removed banner text Apr 14, 2017

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 14, 2017

Looks good, merging.

@philippjfr philippjfr merged commit d460fa0 into master Apr 14, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 78.789%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the restore_logo_option branch Apr 14, 2017

@jbednar

This comment has been minimized.

Member

jbednar commented Apr 14, 2017

Excellent; thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment