New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for GridImage deprecation in OptsSpec parser #1292

Merged
merged 2 commits into from Apr 14, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Apr 14, 2017

This PR addresses issue #1252 by converting 'GridImage' to 'Image' in the opts parser. Here is an example of what it does:

image

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 14, 2017

@philippjfr In raster.py we have:

GridImage = Image

Would it be worth wrapping GridImage as a subclass of Image, just to issue a deprecation warning in the constructor?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 14, 2017

Would it be worth wrapping GridImage as a subclass of Image, just to issue a deprecation warning in the constructor?

Not a bad idea.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 14, 2017

Now when you try to build a GridImage:

image

@jlstevens jlstevens added the ready label Apr 14, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 14, 2017

@philippjfr Ready to review.

I think this PR should make things easier for anyone who might be using GridImage. You could try very fancy things (e.g remapping the option tree) but I think these simple changes should do the trick.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 14, 2017

This PR addresses issue #1252 by converting 'GridImage' to 'Image' in the opts parser.

This does miss any explicitly assigning to the option tree which I've used in a few places. But since anything else is bound to be complex I'm fine with this since we also have the warning. Will merge when tests pass.

@philippjfr philippjfr merged commit cf33ce1 into master Apr 14, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 78.782%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the gridimage_deprecation branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment