New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated max_branches output magic option #1293

Merged
merged 6 commits into from Apr 14, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Apr 14, 2017

This PR addresses #1026 by deprecating the display method on Layout and the max_branches option of the output magic. All Layouts should now be displayed consistently.

The only potential improvement might be to use param.warning instead of a print statement. I'm not sure this is necessary though as the output magic isn't normal user API and isn't parameterized. In this case a simple print statement seems fine instead of using the global param logger which isn't ideal in any case.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 14, 2017

Looks good, will merge when tests pass (and I'm back from lunch).

@philippjfr philippjfr merged commit 951ef20 into master Apr 14, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 78.762%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the layout_display_fix branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment