New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attach stream subscribers to batched ElementPlot #1301

Merged
merged 2 commits into from Apr 17, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 17, 2017

Batched plots create both an OverlayPlot and an ElementPlot instance which currently both attach themselves as stream subscribers, however the correct thing to do is for only the OverlayPlot to attach itself so that the batched plot is updated correctly.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 17, 2017

Are there any unit tests that could make sure the correct things are attacked as subscribers when batched?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 17, 2017

Are there any unit tests that could make sure the correct things are attacked as subscribers when batched?

Sure I can add one.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 17, 2017

New unit test looks good. I'll merge once the tests go green.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 17, 2017

Tests are green. Merging.

@jlstevens jlstevens merged commit dd5d754 into master Apr 17, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 78.92%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the attach_batched_streams branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment