New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach linked streams in batched mode #1439

Merged
merged 2 commits into from May 15, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented May 15, 2017

In batched mode linked streams weren't being attached, previously this would have been handled by the OverlayPlot wrapping the batched plot. I think this fix won't cause any issues but I'll run through examples now to double check.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 15, 2017

Happy to merge once you've tested it a bit as the change itself is very simple.

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 15, 2017

Added a unit test and ran through my examples without encountering issues.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 15, 2017

Tests have now passed. Merging.

@jlstevens jlstevens merged commit 9909c29 into master May 15, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 78.858%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the batched_streams_fix branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment