New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bokeh toolbar when set to None #1442

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented May 15, 2017

Seems to have been an indentation issue, but I've also ensured the toolbar option is propagated to the OverlayPlot. Layouts and Grids probably needs their own way of disabling and placing toolbars, but that's a separate issue.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 15, 2017

Ready to merge?

I know it isn't likely to be tests properly but I'll still wait till at least some of the tests turn green.

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 16, 2017

Yes, ready to merge.

@jlstevens jlstevens merged commit b032bff into master May 16, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 78.858%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the toolbar_fix branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment