New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing inargs and inkwargs as Callable.args and .kwargs #1453

Merged
merged 2 commits into from May 18, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented May 18, 2017

Simple PR to address #1307 - before it is called the callable .args and .kwargs attributes are None, afterwards they reflect how the callable was invoked.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 18, 2017

@philippjfr Ready to review/merge once the tests are green.

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 18, 2017

Looks good, merging.

@philippjfr philippjfr merged commit 5d89ade into master May 18, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 78.703%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the callable_info branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment