New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for BokehRenderer.server_doc for plots with widgets #1469

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented May 21, 2017

This fixes a bug in the BokehRenderer.server_doc method, which resulted in the bokeh widgets not being added to the Document and therefore not appearing.

@philippjfr philippjfr added the bug label May 21, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 21, 2017

Looks good. Any thoughts on how we will test the bokeh app functionality?

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 21, 2017

Looks good. Any thoughts on how we will test the bokeh app functionality?

I'll have a look at how bokeh tests server app functionality but I think we should be able to do some actual testing by starting up a server and perhaps connecting to it with a separate client.

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 22, 2017

I think we should do this separately though. Can we merge this for now?

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 22, 2017

Can we merge this for now?

Sure!

@jlstevens jlstevens merged commit 9e1f7d6 into master May 22, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 78.828%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the bokeh_app_fix branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment