Made BokehRenderer.server_doc method more general #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlstevens
reviewed
May 25, 2017
holoviews/plotting/bokeh/renderer.py
Outdated
| @@ -155,18 +155,23 @@ def show_callback(): | |||
| return server | |||
|
|
|||
|
|
|||
| def server_doc(self, plot, doc=None): | |||
| @bothmethod | |||
| def server_doc(self_or_cls, plot, doc=None): | |||
There was a problem hiding this comment.
Isn't it really plot_or_obj? I would consider renaming plot to obj as a plot is a type of object...
There was a problem hiding this comment.
Do you not agree with this suggestion then?
There was a problem hiding this comment.
Suppose I should make the other methods consistent though.
philippjfr
force-pushed
the
bokeh_server_doc
branch
from
388f3d3
to
fff92d4
Compare
philippjfr
force-pushed
the
bokeh_server_doc
branch
from
fff92d4
to
80096fc
Compare
|
Ready to merge. |
|
Looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BokehRenderer.server_doc method was mostly used internally to create and attach a plot to a bokeh Document and return it. Apart from fixing a bug attaching the periodic utility, this PR allows the method to be called directly with a HoloViews object.