New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made BokehRenderer.server_doc method more general #1486

Merged
merged 1 commit into from May 29, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented May 25, 2017

The BokehRenderer.server_doc method was mostly used internally to create and attach a plot to a bokeh Document and return it. Apart from fixing a bug attaching the periodic utility, this PR allows the method to be called directly with a HoloViews object.

@@ -155,18 +155,23 @@ def show_callback():
return server
def server_doc(self, plot, doc=None):
@bothmethod
def server_doc(self_or_cls, plot, doc=None):

This comment has been minimized.

@jlstevens

jlstevens May 25, 2017

Member

Isn't it really plot_or_obj? I would consider renaming plot to obj as a plot is a type of object...

This comment has been minimized.

@jlstevens

jlstevens May 29, 2017

Member

Do you not agree with this suggestion then?

This comment has been minimized.

@philippjfr

philippjfr May 29, 2017

Member

I implemented it.

This comment has been minimized.

@jlstevens

jlstevens May 29, 2017

Member

Ah I see it. Thanks!

This comment has been minimized.

@philippjfr

philippjfr May 29, 2017

Member

Suppose I should make the other methods consistent though.

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 29, 2017

Ready to merge.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 29, 2017

Looks good. Merging.

@jlstevens jlstevens merged commit 1f47e7a into master May 29, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 78.96%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the bokeh_server_doc branch Jun 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment