New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for static bokeh png rendering #1493

Merged
merged 2 commits into from May 29, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented May 29, 2017

The bokeh 0.12.6 release will add static png rendering support and this PR exposes this support at the bokeh renderer level. Because rendering to png is so slow this is not particularly useful for working interactively but will be very useful for generating output which can be embedded in any document, including the thumbnails for our gallery.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 29, 2017

Happy to merge this simple addition. My only worry is we need to keep testing it to make sure it continues to work as the Bokeh export API evolves. Might be worth having a unit test that just checks that a PNG file is generated (without trying to check the contents).

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 29, 2017

Might be worth having a unit test that just checks that a PNG file is generated (without trying to check the contents).

Sounds reasonable.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 29, 2017

I suppose getting this unit tests working means updating the bokeh version on Travis. Alternatively, we could annotate such tests like we do with 'optional' to skip them for now...

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 29, 2017

Alternatively, we could annotate such tests like we do with 'optional' to skip them for now...

It is marked optional, just like the other bokeh renderer tests.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 29, 2017

It is marked optional, just like the other bokeh renderer tests.

We need a new annotation as Travis runs all tests (doesn't use -a '!optional') right now. I'm proposing an annotation that means 'don't run on travis yet' or 'will be run on travis once ready and this annotation is removed'.

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 29, 2017

I'm proposing an annotation that means 'don't run on travis yet' or 'will be run on travis once ready and this annotation is removed'.

Seems easier to just add a SkipTest that checks the bokeh version for now.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 29, 2017

Seems easier to just add a SkipTest that checks the bokeh version for now.

Good idea.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 29, 2017

There is no need to ever remove the version check for the SkipTest either. When you say 'for now', I am happy with 'forever'! :-)

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 29, 2017

The pr builds are green so I'll merge once the push build is green as well.

@jlstevens jlstevens merged commit 93d5058 into master May 29, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.975%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the bokeh_png_export branch May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment