New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed using xarray with dask arrays #1512

Merged
merged 3 commits into from Jun 4, 2017

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Jun 2, 2017

XArray supports wrapping around dask arrays. Generally this doesn't cause any issues but the dimension_values method should always return an in-memory NumPy array so this PR is sufficient for us to have full support for dask arrays via xarray.

@philippjfr philippjfr added the data label Jun 2, 2017

@jbednar

jbednar approved these changes Jun 2, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 2, 2017

Looks good!

I had a prototype line like this once before but supporting dask via xarray makes sense. My main comment is that a few unit tests would be nice (marked optional and dask would need to be available on travis).

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 4, 2017

I'm now running all existing Dataset tests against an xarray dataset containing dask arrays. Those 60 unit tests should cover it pretty well.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 4, 2017

I'll merge when the tests go green.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 4, 2017

Hold off on merging, found some issues.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 4, 2017

Okay, now fixed. Ready to merge once tests pass.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 4, 2017

Tests have passed. Merging.

@jlstevens jlstevens merged commit a213f38 into master Jun 4, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 79.12%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the xarray_dask branch Jun 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment