New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced usage of deleted stack_area operation #1515

Merged
merged 1 commit into from Jun 4, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jun 4, 2017

stack_area was removed, replaced with Area.stack

@philippjfr philippjfr added the docs label Jun 4, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 4, 2017

Thanks!

I'm guessing these files didn't yet exist in the repo (or on that branch) when I grepped to make this change.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 4, 2017

I'm pretty sure they must have been around at that point. Simple fix though.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 4, 2017

No need to wait on tests tbh, not tested yet anyway.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 4, 2017

I'm pretty sure they must have been around at that point.

Odd. I'm sure I grepped for that string. Anyway, merging.

@jlstevens jlstevens merged commit e6ded88 into master Jun 4, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on area_chart_fix at 79.289%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the area_chart_fix branch Jun 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment