New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for computing spreadfn aggregates #1543

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jun 15, 2017

Fixed a small bug when aggregating with a spreadfn. In writing unit tests for this I also noticed that pandas uses ddof=1 (delta degrees of freedom) while the numpy default is ddof=0. I've adjusted the code to catch those cases and change the pandas version to ddof=0.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 15, 2017

Looks like I need to rebuild test data, the Columnar_Data examples of using the spread function were using pandas and are therefore affected by the ddof change.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 15, 2017

Sounds like a bad bug - glad it is fixed and I'll merge once the tests are passing again.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 15, 2017

Tests are green. Merging.

@jlstevens jlstevens merged commit 1c26f67 into master Jun 15, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 79.288%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the dataset_agg_fix branch Jun 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment