New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BoundsX/BoundsY streams #1554

Merged
merged 3 commits into from Jun 16, 2017

Conversation

Projects
None yet
4 participants
@jordansamuels
Contributor

jordansamuels commented Jun 16, 2017

  • Core code is thanks to @philippjfr via gitter
  • Added notebook examples and animated gifs
  • Fixed mismatch in Bounds.bounds doc string
Jordan Samuels
Add BoundsX/BoundsY streams
* Core code is thanks to @philippjfr via gitter
* Added notebook examples and animated gifs
* Fixed mismatch in Bounds.bounds doc string
@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 16, 2017

Thanks so much for those examples, they look great! We're not including the gifs directly in the repo at least for now. I'll upload them to assets.holoviews.org in the morning, then you can link to them from the notebook.

@jordansamuels

This comment has been minimized.

Contributor

jordansamuels commented Jun 16, 2017

@philippjfr understood. In the end, I went with a different set of examples than what we discussed.

@jbednar

This comment has been minimized.

Member

jbednar commented Jun 16, 2017

Very nice!

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 16, 2017

Thank you! Those examples look great!

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 16, 2017

I have now uploaded these to our assets bucket, you can display them in the notebooks by linking to:

http://assets.holoviews.org/gifs/examples/streams/bokeh/boundsx_selection.gif
http://assets.holoviews.org/gifs/examples/streams/bokeh/boundsy_selection.gif

Once you've removed them from this PR and updated the notebooks, this is ready to merge. That will be our first user contributed gallery example, thanks again!

Jordan Samuels added some commits Jun 16, 2017

Jordan Samuels
Minor fixes to examples
* Replace boundsx demo gif with assets link
* Fix minor error in boundsy notebook
* New boundsy gif, will replace with assets link on next commit
@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 16, 2017

Thanks so much for adding this. I'll go ahead and merge now.

@philippjfr philippjfr merged commit 8f4eb66 into ioam:master Jun 16, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.1%) to 79.269%
Details
s3-reference-data-cache Test data is cached.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment