New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zero values in logz colormapping for mpl #1576

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jun 19, 2017

Matplotlib throws an exception when using LogNorm colormapping and the vmin is zero. Now uses the smallest non-zero value.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 19, 2017

Looks good. Happy to merge when the tests pass.

@philippjfr philippjfr added the mpl label Jun 19, 2017

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 19, 2017

Okay, ready to merge. You can rebase your mandelbrot PR once this is merged and use logz in both backends.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 19, 2017

Great! Will do.

@jlstevens jlstevens merged commit 5a40120 into master Jun 19, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 79.678%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the mpl_logz_zeros branch Jun 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment