New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DynamicMap.opts method to apply opts to returned object #1589

Merged
merged 2 commits into from Jun 21, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jun 20, 2017

When applying opts to a DynamicMap using the .opts method the options sometimes aren't applied correctly. By mapping the applied opts on the DynamicMap the opts are applied directly to the returned Elements. I think the issue may be that the id doesn't get copied or applied correctly, which means that the DynamicMap._style method doesn't apply the options correctly.

@philippjfr philippjfr added the bug label Jun 20, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 21, 2017

Tests are now passing. Merging.

@jlstevens jlstevens merged commit 47c3ecd into master Jun 21, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 79.821%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the dmap_style branch Jun 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment