New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added case_sensitive_completion option to extension #1613

Merged
merged 3 commits into from Jun 26, 2017

Conversation

Projects
None yet
3 participants
@jlstevens
Member

jlstevens commented Jun 26, 2017

This fixes a bug with recent IPython versions, namely the fact that completions are listed in a case-insensitive order (ignoring both the default behavior of dir and __dir__ as well as the semantic importance of case in Python identifiers).

As this monkey patches a particular function in IPython, the default of this parameter is False but you can enable it by adding a ~/.holoviews.rc:

import holoviews as hv
hv.extension.case_sensitive_completion=True

This is highly recommended as it allows you to index into Layout and Overlayas originally intended. Hopefully, this fix will make it's way into the next IPython release.

@jbednar

This comment has been minimized.

Member

jbednar commented Jun 26, 2017

Looks good to me.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 26, 2017

I've improved handling of the holoviews.rc file. You can now stick a 'holoviews.rc' at the top-level of the git repo and it will be used, instead of having to stick the file in the home directory (or using an environment variable).

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 26, 2017

@jbednar @philippjfr I am open to suggestions for a better name than case_sensitive_completion. Otherwise ready for review.

@jbednar

This comment has been minimized.

Member

jbednar commented Jun 26, 2017

Looks good to me. Ready to merge?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 26, 2017

Will merge once tests pass.

@philippjfr philippjfr merged commit e5a79b9 into master Jun 26, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 79.813%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the sorted_completions_fix branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment