New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table finalize hook fix and example #1711

Merged
merged 3 commits into from Jul 14, 2017

Conversation

Projects
None yet
2 participants
@jordansamuels
Contributor

jordansamuels commented Jul 10, 2017

One solution to #1708

Jordan Samuels added some commits Jul 10, 2017

Jordan Samuels
Jordan Samuels
Minor tweak to notebook
* add additional URL
* committing mostly to test failing Travis build
@jordansamuels

This comment has been minimized.

Contributor

jordansamuels commented Jul 11, 2017

(My additional commits were in confusion as I forgot it's another PR that's failing the Travis build.)

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 11, 2017

Thanks for this!

We started adding little feature examples just like this one in holoviews-contrib and we haven't yet found a new home for them (see this example which is very similar).

Discussing this with Philipp, we think this can be the first example in /examples/reference/features/bokeh. Could you please initialize those directories and move your example there?

@jlstevens jlstevens changed the title from https://github.com/ioam/holoviews/issues/1708 to Table finalize hook fix and example Jul 11, 2017

@jlstevens jlstevens added the bokeh label Jul 11, 2017

@jordansamuels

This comment has been minimized.

Contributor

jordansamuels commented Jul 13, 2017

@jlstevens yes, will reorganize and add the example soon. Thanks.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 14, 2017

@jordansamuels Thanks!

PR looks good merging.

@jlstevens jlstevens merged commit 3035c7d into ioam:master Jul 14, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 79.657%
Details
s3-reference-data-cache Test data is cached.
Details

@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment