New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and minor code fixes #1759

Merged
merged 3 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@ea42gh
Contributor

ea42gh commented Jul 27, 2017

hope this works:
changed __call__ to .opts() in 3 files

jordansamuels pushed a commit to jordansamuels/holoviews that referenced this pull request Jul 27, 2017

Jordan Samuels
Replace (...) with .opts()
* Complements ioam#1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks
@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 27, 2017

@ea42gh @jordansamuels Thank you both - this is really helpful!

I wasn't looking forward to updating all these references myself but you two seem to have sorted it out! Skimming the diff here, the changes all look right but I'll have another pass before merging.

This PR should probably be merged first and then I can review and merge @jordansamuels PR.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 27, 2017

Yup, all looks good!

Merging.

@jlstevens jlstevens merged commit dcf4a61 into ioam:master Jul 27, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.611%
Details
s3-reference-data-cache Test data is cached.
Details

jordansamuels pushed a commit to jordansamuels/holoviews that referenced this pull request Jul 27, 2017

Docs and minor code fixes (ioam#1759)
* __call__ to .opts() mods

* __call__ to .opts() mods

* __call__ to .opts() mods

jordansamuels pushed a commit to jordansamuels/holoviews that referenced this pull request Jul 27, 2017

Jordan Samuels
Replace (...) with .opts()
* Complements ioam#1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks

@jordansamuels jordansamuels referenced this pull request Jul 27, 2017

Merged

Add opts in doc 2 #1763

jlstevens added a commit that referenced this pull request Jul 27, 2017

Add opts in doc 2 (#1763)
* Replace (...) with .opts()

* Complements #1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks

* A few more cases thanks to @ea42gh

* Manually search `git grep ')(' -- examples | grep -vE '.{255}'
* Fix cases by hand
`

@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment