New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opts in doc 2 #1763

Merged
merged 2 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@jordansamuels
Contributor

jordansamuels commented Jul 27, 2017

Cleaner version of #1760, which inadvertently picked up #1759 during a rebase.

Jordan Samuels added some commits Jul 27, 2017

Jordan Samuels
Replace (...) with .opts()
* Complements #1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks
Jordan Samuels
A few more cases thanks to @ea42gh
* Manually search `git grep ')(' -- examples | grep -vE '.{255}'
* Fix cases by hand
`
@jlstevens

This comment has been minimized.

Member

jlstevens commented Jul 27, 2017

Having skimmed the diff, all the changes look correct to me. As the tests are green, I think it is better to merge sooner than later. I'm sure there will be other places that __call__ need to be replaced but having this merged will make those other instances easier to find.

@jordansamuels Thanks again for this PR! Merging.

@jlstevens jlstevens merged commit 350b323 into ioam:master Jul 27, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.611%
Details
s3-reference-data-cache Test data is cached.
Details

@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment