New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML fix in logo for export #1778

Merged
merged 2 commits into from Aug 2, 2017

Conversation

Projects
None yet
3 participants
@jlstevens
Member

jlstevens commented Aug 2, 2017

PR to address #1769. The current commit (removing inner divs) fixes the export. The problem is that the logos now look like this:

image

As opposed to the previous arrangement that was:

image

With all three logos, it now looks like:

image

Which I don't quite like as much but either way, fixing the export is far more important than the arrangement of the logos!

@jbednar

This comment has been minimized.

Member

jbednar commented Aug 2, 2017

I like the new one much better!

@philippjfr

This comment has been minimized.

Member

philippjfr commented Aug 2, 2017

I'm happy with it too, I'll go ahead and merge.

@philippjfr philippjfr merged commit 5fa48c8 into master Aug 2, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.616%
Details
s3-reference-data-cache Test data is cached.
Details

ea42gh added a commit to ea42gh/holoviews that referenced this pull request Aug 12, 2017

HTML fix in logo for export (ioam#1778)
* Removed inner divs in logo to fix export

* Removed vertical-align style as it has no effect

@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017

@philippjfr philippjfr deleted the div_logo_fix branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment