New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed jinja templating when logo=False #1809

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Aug 18, 2017

Minor fix to address #1797.

One annoyance I don't know how to fix yet is the vertical whitespace above the logo. Here are the divs responsible but I don't know what is generating them:

image

@philippjfr If you don't have any ideas how to fix that whitespace, this PR is ready to merge.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Aug 18, 2017

The whitespace comes from loading bokehJS in the extension so I don't think we can easily avoid it. Will merge once the PR build passes.

@philippjfr philippjfr merged commit f0b4937 into master Aug 18, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.474%
Details
s3-reference-data-cache Test data is cached.
Details
@philippjfr

This comment has been minimized.

Member

philippjfr commented Aug 18, 2017

For reference, you can reproduce the whitespace with:

from bokeh.io import load_notebook
load_notebook(hide_banner=True)

Not sure there's anything bokeh can do about it though.

@jbednar jbednar deleted the no_logo_div_fix branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment