New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for changes to categorical handling in bokeh 0.12.7 #1849

Merged
merged 5 commits into from Sep 4, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Sep 4, 2017

Addresses #1839 by adding support for the new categorical handling to bokeh Bar plots.

Old Bars:

screen shot 2017-09-04 at 2 00 35 pm

New Bars:

screen shot 2017-09-04 at 2 14 29 pm

Old BoxWhisker:

screen shot 2017-09-04 at 2 15 04 pm

New BoxWhisker:

screen shot 2017-09-04 at 2 12 14 pm

@philippjfr philippjfr added the bokeh label Sep 4, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Sep 4, 2017

Looks good and the tests seem to be passing. Ready to merge?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Sep 4, 2017

Just pushed one more commit which should also address #1091 going forward.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Sep 4, 2017

@jlstevens Ready to merge now.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Sep 4, 2017

When bokeh 1.0 comes out I hope we can get rid of all these version conditionals for all prior versions. Anyway, merging.

@jlstevens jlstevens merged commit 39a8f50 into master Sep 4, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 79.61%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the bokeh_categorical_fixes branch Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment